-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way for Darwin invokes to specify a server-side processing timeout. #24552
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:add-invoke-timeout-control
Jan 21, 2023
Merged
Add a way for Darwin invokes to specify a server-side processing timeout. #24552
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:add-invoke-timeout-control
Jan 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
mspang and
pjzander-signify
January 20, 2023 15:40
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 20, 2023 15:40
yunhanw-google
approved these changes
Jan 20, 2023
PR #24552: Size comparison from e48fe6a to 305f9c5 Increases (2 builds for bl602, telink)
Decreases (9 builds for bl702, esp32, k32w, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
add-invoke-timeout-control
branch
from
January 20, 2023 18:32
305f9c5
to
445e13b
Compare
anush-apple
approved these changes
Jan 20, 2023
jtung-apple
approved these changes
Jan 20, 2023
PR #24552: Size comparison from 7e3d712 to 445e13b Increases (3 builds for cc13x2_26x2, nrfconnect, qpg)
Decreases (12 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…out. The default 2s timeout is way too low for some commands (like ScanNetworks). Fixes project-chip#24333
bzbarsky-apple
force-pushed
the
add-invoke-timeout-control
branch
from
January 20, 2023 21:56
445e13b
to
17a298d
Compare
PR #24552: Size comparison from 28778b8 to 17a298d Increases (5 builds for cyw30739, telink)
Decreases (8 builds for bl702, esp32, nrfconnect, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
msandstedt
approved these changes
Jan 21, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…out. (project-chip#24552) The default 2s timeout is way too low for some commands (like ScanNetworks). Fixes project-chip#24333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default 2s timeout is way too low for some commands (like ScanNetworks).
Fixes #24333